linux-kernel - Re: [PATCH 06/10] video/uvc: use memweight()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7559275.nOXNfWAdxV@avalon>
Date:	Sun, 20 May 2012 22:46:35 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Akinobu Mita <akinobu.mita@...il.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	linux-media@...r.kernel.org
Subject: Re: [PATCH 06/10] video/uvc: use memweight()

Hi Akinobu,

Thank you for the patch.

On Sunday 20 May 2012 22:23:19 Akinobu Mita wrote:
> Use memweight() to count the total number of bits set in memory area.
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>
> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Cc: linux-media@...r.kernel.org

Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  drivers/media/video/uvc/uvc_ctrl.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/video/uvc/uvc_ctrl.c
> b/drivers/media/video/uvc/uvc_ctrl.c index 0efd3b1..8683be0 100644
> --- a/drivers/media/video/uvc/uvc_ctrl.c
> +++ b/drivers/media/video/uvc/uvc_ctrl.c
> @@ -1851,7 +1851,7 @@ int uvc_ctrl_init_device(struct uvc_device *dev)
>  	/* Walk the entities list and instantiate controls */
>  	list_for_each_entry(entity, &dev->entities, list) {
>  		struct uvc_control *ctrl;
> -		unsigned int bControlSize = 0, ncontrols = 0;
> +		unsigned int bControlSize = 0, ncontrols;
>  		__u8 *bmControls = NULL;
> 
>  		if (UVC_ENTITY_TYPE(entity) == UVC_VC_EXTENSION_UNIT) {
> @@ -1869,8 +1869,7 @@ int uvc_ctrl_init_device(struct uvc_device *dev)
>  		uvc_ctrl_prune_entity(dev, entity);
> 
>  		/* Count supported controls and allocate the controls array */
> -		for (i = 0; i < bControlSize; ++i)
> -			ncontrols += hweight8(bmControls[i]);
> +		ncontrols = memweight(bmControls, bControlSize);
>  		if (ncontrols == 0)
>  			continue;

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/