linux-kernel - Re: [PATCH 03/10] qnx4fs: use memweight()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC5umygC0q03_fPc-bF66whusw=ieXv_5A3hOniMs5=MRd7BMw@mail.gmail.com>
Date:	Mon, 21 May 2012 20:59:59 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Anders Larsen <al@...rsen.net>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH 03/10] qnx4fs: use memweight()

2012/5/21 Anders Larsen <al@...rsen.net>:

>> @@ -44,13 +27,16 @@ unsigned long qnx4_count_free_blocks(struct
>> super_block *sb)
>>        struct buffer_head *bh;
>>
>>        while (total < size) {
>> +               int bytes = min(size - total, QNX4_BLOCK_SIZE);
>> +
>>                if ((bh = sb_bread(sb, start + offset)) == NULL) {
>>                        printk(KERN_ERR "qnx4: I/O error in counting free
>> blocks\n");
>>                        break;
>>                }
>> -               count_bits(bh->b_data, size - total, &total_free);
>> +               total_free += bytes * BITS_PER_BYTE-
>
>
> due to the missing whitespace after the macro I had to read that statement
> three times to comprehend it (which was probably good, since that's the beef
> ;)

Oh, checkpatch.pl also couldn't detect it.

>> +                               memweight(bh->b_data, bytes);
>>                brelse(bh);
>> -               total += QNX4_BLOCK_SIZE;
>> +               total += bytes;
>>                offset++;
>>        }
>
>
> Other than that,
> Acked-by: Anders Larsen <al@...rsen.net>

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/