linux-kernel - Re: [PATCH v3 1/2] x86: Define early read-mostly per-cpu macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40553348.tpY4157LUQ@vlad>
Date:	Mon, 21 May 2012 16:27:01 +0300
From:	Vlad Zolotarov <vlad@...lemp.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Shai Fultheim (Shai@...leMP.com)" <Shai@...lemp.com>,
	Ido Yariv <ido@...ery.com>
Subject: Re: [PATCH v3 1/2] x86: Define early read-mostly per-cpu macros

> > 
> > Thanks, Ingo. I understand. However the "history" of this
> > patch is not as simple as u represent. ;)
> > 
> > It was originally written by Ido and I just posted it (then I
> > put my SOB at the end of SOB list). But after u noted that it
> > didn't compile on !SMP i reworked it but yet Ido did at least
> > half of the coding, so I put my SOB at the first place (as I
> > was the last one writing the code) and then Ido's as he
> > actually wrote the code in this patch as well and I do wanted
> > to give him a credit.
> 
> The proper way to do that is to add a "Originally-From: " tag,
> or to keep him as the author (and first SOB) and desccribe your
> own changes as comments between the SOBs:
> 
>  Signed-off-by: Original Author
>  [ cleaned up the code a bit ]
>  Signed-off-by: Second Author
>  [ restructured it ]
>  Signed-off-by: You
> 
> > Do u still think changing his (Ido's) SOB to Acked-by was the
> > right thing to do?
> 
> If they agree with it then you can send it to me that way - or
> the above way, or you can add any extra authors in a copyright
> notice - but the signoff chain should be a chain, with the
> primary author as the first SOB and the person sending me the
> patch being the last SOB.

Got it. I think the "above" way would describe the reality in the most exact 
manner and would give the credit in the most exact manner.

I'd like to respin the series if it's still possible. 
Pls., let me know.

thanks,
vlad

> 
> Thanks,
> 
> 	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/