linux-kernel - Re: NMI vs #PF clash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1337696825.13348.44.camel@gandalf.stny.rr.com>
Date:	Tue, 22 May 2012 10:27:05 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Avi Kivity <avi@...hat.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Paul Turner <pjt@...gle.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: NMI vs #PF clash

On Tue, 2012-05-22 at 17:20 +0300, Avi Kivity wrote:
> On 05/22/2012 05:09 PM, Steven Rostedt wrote:
> >> > 
> >> > Or we could just have the NMI always restore the cr2 register.
> >> 
> >> IMO that's best.
> > 
> > OK, I can whip up a patch, but I wont push that in till 3.6.
> > 
> 
> Thanks.  Something I've noticed is that writing cr2 is slow, so you may
> want to write it only if it has changed (which should be very rare).
> 

Is reading it fast? Then we could do a two reads and only write when
needed.

Something like this pseudo assembly
 
	mov cr2, rax
	push rax

	call do_nmi

	pop rax
	mov cr2, rbx
	cmp rax, rbx
	be skip
	mov rax, cr2
skip:


-- Steve



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/