linux-kernel - Bug in sysfs bin attribute?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 May 2012 22:38:11 -0700
From:	Vikas Chaudhary <vikas.chaudhary@...gic.com>
To:	linux-kernel <linux-kernel@...r.kernel.org>
CC:	Mike Christie <michaelc@...wisc.edu>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Vikas Chaudhary <vikas.chaudhary@...gic.com>,
	Lalit Chandivade <lalit.chandivade@...gic.com>,
	Ravi Anand <ravi.anand@...gic.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: Bug in sysfs bin attribute?

We have added sysfs bin_attribute 'fw_dump' in qla4xxx driver.
Here is patch for same: -
http://marc.info/?l=linux-scsi&m=133733192809849&w=2

In this patch in function qla4_8xxx_sysfs_write_fw_dump() if we print
string coming in 'char *buf'
from sysfs attribute it contain value we echo on sysfs attribute 'fw_dump'
plus some garbage data.

If I write "5" to sysfs attribute I am getting following string in buf : -

May 18 12:08:00 magana kernel: ----------------
May 18 12:08:00 magana kernel: buf: 5
May 18 12:08:00 magana kernel: /../../host10           <-- Garbage data
May 18 12:08:00 magana kernel: ----------------

Because of this garbage data kstrtol() fails in function
qla4_8xxx_sysfs_write_fw_dump().
If we use simple_strtol() instate of kstrtol() it works well. But
simple_strtol() is deprecated
so we can't use this API.
Solution to this, for now are writing "0" at buf[1] as we are interested
only in value at buf[0].

I am interested to know if the behavior of sysfs attribute is correct or
is it an issue?

Thanks,
Vikas.

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/