linux-kernel - Re: Bug in sysfs bin attribute?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120523061712.GA19773@kroah.com>
Date:	Tue, 22 May 2012 23:17:12 -0700
From:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:	Vikas Chaudhary <vikas.chaudhary@...gic.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Mike Christie <michaelc@...wisc.edu>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Lalit Chandivade <lalit.chandivade@...gic.com>,
	Ravi Anand <ravi.anand@...gic.com>
Subject: Re: Bug in sysfs bin attribute?

On Tue, May 22, 2012 at 10:38:11PM -0700, Vikas Chaudhary wrote:
> 
> We have added sysfs bin_attribute 'fw_dump' in qla4xxx driver.
> Here is patch for same: -
> http://marc.info/?l=linux-scsi&m=133733192809849&w=2
> 
> 
> In this patch in function qla4_8xxx_sysfs_write_fw_dump() if we print
> string coming in 'char *buf'
> from sysfs attribute it contain value we echo on sysfs attribute 'fw_dump'
> plus some garbage data.

Why are you not using the built-in firmware interface the kernel
provides you?  What does it lack that you need here?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/