linux-kernel - Re: [PATCH] Trivial sched: Pass domain_attr to build_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1337759338.9698.45.camel@twins>
Date:	Wed, 23 May 2012 09:48:58 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...hat.com
Subject: Re: [PATCH] Trivial sched: Pass domain_attr to build_sched_domains()

On Wed, 2012-05-23 at 12:11 +0530, Kamalesh Babulal wrote:
> sched: Pass domain_attr to build_sched_domains()
> 
> build_sched_domains() is called from init_sched_domains()
> by explicitly passing NULL as second argument, which is
> of type sched_domain_attr. This patch calls build_sched_domains()
> with dattr_cur instead of NULL, as dattr_cur is also NULL.

So what's the point? Rather clean up the dattr crap, no?

> Signed-off-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
> ---
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 22a19ae..32ccf13 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -6735,7 +6735,7 @@ static int init_sched_domains(const struct cpumask *cpu_map)
>  		doms_cur = &fallback_doms;
>  	cpumask_andnot(doms_cur[0], cpu_map, cpu_isolated_map);
>  	dattr_cur = NULL;
> -	err = build_sched_domains(doms_cur[0], NULL);
> +	err = build_sched_domains(doms_cur[0], dattr_cur);
>  	register_sched_domain_sysctl();
> 
>  	return err;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/