linux-kernel - Re: [PATCH] Trivial sched: Pass domain_attr to build_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120523091411.GG5005@linux.vnet.ibm.com>
Date:	Wed, 23 May 2012 14:44:11 +0530
From:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...hat.com
Subject: Re: [PATCH] Trivial sched: Pass domain_attr to build_sched_domains()

* Peter Zijlstra <peterz@...radead.org> [2012-05-23 09:48:58]:

> On Wed, 2012-05-23 at 12:11 +0530, Kamalesh Babulal wrote:
> > sched: Pass domain_attr to build_sched_domains()
> > 
> > build_sched_domains() is called from init_sched_domains()
> > by explicitly passing NULL as second argument, which is
> > of type sched_domain_attr. This patch calls build_sched_domains()
> > with dattr_cur instead of NULL, as dattr_cur is also NULL.
> 
> So what's the point? Rather clean up the dattr crap, no?

Thanks for the review.

As suggested, this version of patch drops dattr_cur from
init_sched_domains().

sched: Remove NULL assignment to dattr_cur

Remove explicit NULL assignment of static pointer
dattr_cur from init_sched_domains().

Signed-off-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
---
 kernel/sched/core.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 22a19ae..964bf9d 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -6734,7 +6734,6 @@ static int init_sched_domains(const struct cpumask *cpu_map)
 	if (!doms_cur)
 		doms_cur = &fallback_doms;
 	cpumask_andnot(doms_cur[0], cpu_map, cpu_isolated_map);
-	dattr_cur = NULL;
 	err = build_sched_domains(doms_cur[0], NULL);
 	register_sched_domain_sysctl();

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/