linux-kernel - Re: [PATCH block/for-3.5/core] blkcg: tg_stats_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FBCB913.8050403@kernel.dk>
Date:	Wed, 23 May 2012 12:16:51 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	Sasha Levin <levinsasha928@...il.com>
CC:	Tejun Heo <tj@...nel.org>, Sasha Levin <sasha.levin@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	paulmck@...ux.vnet.ibm.com
Subject: Re: [PATCH block/for-3.5/core] blkcg: tg_stats_alloc_lock is an irq
 lock

On 05/23/2012 11:54 AM, Sasha Levin wrote:
> On Thu, Apr 26, 2012 at 11:10 PM, Tejun Heo <tj@...nel.org> wrote:
>> tg_stats_alloc_lock nests inside queue lock and should always be held
>> with irq disabled.  throtl_pd_{init|exit}() were using non-irqsafe
>> spinlock ops which triggered inverse lock ordering via irq warning via
>> RCU freeing of blkg invoking throtl_pd_exit() w/o disabling IRQ.
>>
>> Update both functions to use irq safe operations.
>>
>> Signed-off-by: Tejun Heo <tj@...nel.org>
>> Reported-by: Sasha Levin <sasha.levin@...cle.com>
>> LKML-Reference: <1335339396.16988.80.camel@...py>
>> ---
> 
> I think that this patch got lost somewhere and never got merged into
> the for-3.5 branch.

Seems it did, odd. Applied it now.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/