[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.44L0.1205231124460.1566-100000@iolanthe.rowland.org>
Date: Wed, 23 May 2012 11:27:19 -0400 (EDT)
From: Alan Stern <stern@...land.harvard.edu>
To: Lin Ming <ming.m.lin@...el.com>
cc: Jens Axboe <axboe@...nel.dk>, <linux-kernel@...r.kernel.org>,
<linux-pm@...r.kernel.org>, <linux-scsi@...r.kernel.org>
Subject: Re: [RFC PATCH v3 0/4]: block layer runtime pm
On Wed, 23 May 2012, Lin Ming wrote:
> On Wed, May 23, 2012 at 11:03 PM, Alan Stern <stern@...land.harvard.edu> wrote:
> > On Wed, 23 May 2012, Lin Ming wrote:
> >
> >> Another thing need to check is if system suspend/resume works.
> >
> > Right! Although I would hope that your work doesn't interfere at all
> > with system sleep, since it touches only the runtime PM pathways.
>
> sd_sync_cache and sd_start_stop_device are changed with REQ_PM set.
> And they are called for system suspend too.
>
> So it probably will have problem.
People have already run into problems where system suspend
occurred at a time when a SCSI device was already runtime suspended.
That's why scsi_bus_suspend_common() includes an appropriate check.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists