linux-kernel - Re: Watchdog settimeout causes an error condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 23 May 2012 18:56:09 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Ashish Jangam <ashish.jangam@...tcummins.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
	Anthony Olech <Anthony.Olech@...semi.com>
Subject: Re: Watchdog settimeout causes an error condition

Hi Ashish,

> The new watchdog framework of settimeout causes an error condition for
> the DA9052/53 PMIC since watchdog ping gets called upon applying the new
> watchdog window and in the DA9052/53 PMIC we have a minimum time for the
> watchdog window called TWDMIN. A write to the watchdog before this
> elapsed time - TWDMIN - cause an error.
> 
> Can this be get fixed in the new framework?

Imho this should not be fixed in the framework but in your driver.
Even if we would change the framework, it will always be possible that
userspace will do a set-timeout and ping directly after each other.

What I would do is make sure that your driver makes sure that you can't write
before this TWDMIN window has passed.

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/