linux-kernel - Re: [PATCH] lib/decompress_unxz.c: removing all memory helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FBE6FF6.5090904@zytor.com>
Date:	Thu, 24 May 2012 10:29:26 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Joe Perches <joe@...ches.com>
CC:	T Makphaibulchoke <tmac@...com>, lethal@...ux-sh.org,
	tglx@...utronix.de, mingo@...hat.com, x86@...nel.org,
	kaloz@...nwrt.org, matt.fleming@...el.com,
	lasse.collin@...aani.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
	linux-sh@...r.kernel.org, linux@....linux.org.uk,
	schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
	linux390@...ibm.com
Subject: Re: [PATCH] lib/decompress_unxz.c: removing all memory helper functions

On 05/24/2012 10:26 AM, Joe Perches wrote:
> On Thu, 2012-05-24 at 10:03 -0600, T Makphaibulchoke wrote:
>> The patch cleans up the file lib/decompress_unxz.c by removing all memory
>> helper functions, e.g., memmove.  By doing so, any architecture's preboot
>> environment supporting the XZ decompression needs to define its own copy of
>> any of the missing memory helper functions.
> 
> Perhaps a silly question, but why not use
> the __builtin variants?

For a lot of cases the __builtin variants just generate a call to the
expected out-of-line function, so you need it anyway.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/