linux-kernel - Re: [PATCH v2 04/14] block: Add bio_clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAC-hyiHNFSiqPAoe9ynokUg1xTS=V32JDYiVHh_qH7ow=0C1fw@mail.gmail.com>
Date:	Thu, 24 May 2012 14:41:24 -0700
From:	Yehuda Sadeh <yehuda@...tank.com>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	Kent Overstreet <koverstreet@...gle.com>,
	linux-kernel@...r.kernel.org, linux-bcache@...r.kernel.org,
	dm-devel@...hat.com, linux-fsdevel@...r.kernel.org, tj@...nel.org,
	axboe@...nel.dk, agk@...hat.com, neilb@...e.de,
	drbd-dev@...ts.linbit.com, bharrosh@...asas.com,
	mpatocka@...hat.com, sage@...dream.net,
	Alex Elder <elder@...tank.com>
Subject: Re: [PATCH v2 04/14] block: Add bio_clone_kmalloc()

On Thu, May 24, 2012 at 11:59 AM, Vivek Goyal <vgoyal@...hat.com> wrote:
> On Wed, May 23, 2012 at 05:02:41PM -0700, Kent Overstreet wrote:
>
> [..]
>> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
>> index 013c7a5..5a953c6 100644
>> --- a/drivers/block/rbd.c
>> +++ b/drivers/block/rbd.c
>> @@ -729,7 +729,7 @@ static struct bio *bio_chain_clone(struct bio **old, struct bio **next,
>>       }
>>
>>       while (old_chain && (total < len)) {
>> -             tmp = bio_kmalloc(gfpmask, old_chain->bi_max_vecs);
>> +             tmp = bio_clone_kmalloc(old_chain, gfpmask);
>>               if (!tmp)
>>                       goto err_out;
>>
>> @@ -751,13 +751,9 @@ static struct bio *bio_chain_clone(struct bio **old, struct bio **next,
>>                       if (!bp)
>>                               goto err_out;
>>
>> -                     __bio_clone(tmp, &bp->bio1);
>> -
>>                       *next = &bp->bio2;
>
> Is this code correct. Now original code might clone bio after split and
> new code will clone the original bio itself and not the split one?
>

Yeah, that's wrong.

Yehuda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/