linux-kernel - Re: [git pull] Input updates for 3.5-rc0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 May 2012 14:44:31 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [git pull] Input updates for 3.5-rc0

On Thu, May 24, 2012 at 2:07 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
> On Thu, May 24, 2012 at 1:59 PM, Dmitry Torokhov
> <dmitry.torokhov@...il.com> wrote:
>>
>> I was concerned about the _next_ device (the one that will be created
>> the moment I plug in the tablet back into the same port) having exact
>> same name as the one that is half dead and clashing in sysfs and
>> elsewhere. We used to have issues with this.
>
> Ok, that's certainly a valid concern.
>
> It's still - I think - really sad/wrong that the device name is then
> so useless than the drivers end up basically not using it.

Ok, so I wonder if we could solve the issue at least partly by
separating the "print name for kernel messages" from the "name used
for /sysfs etc".

Because you're right: the sysfs uniqueness rules does make it very
hard to do a good job on descriptive names.

Also, in sysfs, you by definition see the parent (hey, it's part of
the path), so in sysfs, duplicating parent data would be useless and
just ugly.

But for dev_dbg(), those sysfs rules actually act against us: the name
of a device is often tied to the parent bus location.

So I wonder if we could teach  dev_printk() to use something more
interesting than "dev_name()" when appropriate? Greg?

                      Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/