linux-kernel - Re: [patch -linus] regmap: REMAP_IRQ should select IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1205232149230.10366@chino.kir.corp.google.com>
Date:	Wed, 23 May 2012 21:53:21 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch -linus] regmap: REMAP_IRQ should select IRQ_DOMAIN
 itself

On Thu, 24 May 2012, Mark Brown wrote:

> > What's fragile is going around and adding "select IRQ_DOMAIN" to 
> > everything that does "select REGMAP_IRQ".  So I removed that and just made 
> > IRQ_DOMAIN select REGMAP_IRQ itself.
> 
> It's a different kind of fragility, things break immediately when you
> add something new which is reasonably obvous as opposed to happening
> at some other time due to a tooling issue and what I'm concerned about
> avoiding.  In any case...
> 

Well pardon me for actually having a cluster of machines at Google 
dedicated to upstream build/boot/regression testing that verified my patch 
was correct and didn't result in any kind of "fragility", or what you have 
convinced yourself is "fragility."

> > So can this be merged or what's the issue?
> 
> ...Linus already merged my alternative patch which does this with a
> select..if which never seems to have these issues.
> 

When you propose your own version, drop all cc's (and this isn't the first 
time you've done that), and then send the git pull request less than 30 
minutes later, I don't really have the chance to review it.  Lesson 
learned, I simply won't bother to fix your code in the future.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/