linux-kernel - Re: [PATCH] dmaengine: pl330: dont complete descriptor for cyclic dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJe_ZhfV6F-X7+M+NYoH4cG1WWU45MTpHsUiWtK406nhjLPHRg@mail.gmail.com>
Date:	Thu, 24 May 2012 10:34:10 +0530
From:	Jassi Brar <jaswinder.singh@...aro.org>
To:	Tushar Behera <tushar.behera@...aro.org>
Cc:	linux-kernel@...r.kernel.org, vinod.koul@...el.com,
	dan.j.williams@...el.com, patches@...aro.org,
	Thomas Abraham <thomas.abraham@...aro.org>
Subject: Re: [PATCH] dmaengine: pl330: dont complete descriptor for cyclic dma

On 24 May 2012 09:54, Tushar Behera <tushar.behera@...aro.org> wrote:
> Forgot to add driver author in the original mail, adding now.
>
> On 05/23/2012 04:47 PM, Tushar Behera wrote:
>> Commit eab215855803 ("dmaengine: pl330: dont complete descriptor for
>> cyclic dma") wrongly completes descriptor for cyclic dma, hence following
>> BUG_ON is still hit with cyclic DMA operations.
>>
>> kernel BUG at drivers/dma/dmaengine.h:53!
>>
>> Signed-off-by: Tushar Behera <tushar.behera@...aro.org>
>> ---
>>  drivers/dma/pl330.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
>> index fa3fb21..8c44f17 100644
>> --- a/drivers/dma/pl330.c
>> +++ b/drivers/dma/pl330.c
>> @@ -2322,7 +2322,7 @@ static void pl330_tasklet(unsigned long data)
>>       /* Pick up ripe tomatoes */
>>       list_for_each_entry_safe(desc, _dt, &pch->work_list, node)
>>               if (desc->status == DONE) {
>> -                     if (pch->cyclic)
>> +                     if (!pch->cyclic)
>>                               dma_cookie_complete(&desc->txd);
>>                       list_move_tail(&desc->node, &list);
>>               }
>
Acked-by: Jassi Brar <jaswinder.singh@...aro.org>

Obviously a typo, but the commit eab2158 had a tested-by, so I hope
this doesn't break something else.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/