linux-kernel - Re: [PATCH] tty: fix ldisc lock inversion trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACVXFVO2bwuPXTzUvY2Vkq9SsF=zqdfV+p-OQjSFL04nBmzywg@mail.gmail.com>
Date:	Fri, 25 May 2012 17:23:38 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: fix ldisc lock inversion trace

On Thu, May 24, 2012 at 11:51 PM, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> From: Alan Cox <alan@...ux.intel.com>
>
> This is caused by tty_release using tty_lock_pair to lock both
> sides of the pty/tty pair, and then tty_ldisc_release dropping
> and relocking one side only. We can drop both fine, so drop both
> to avoid any lock ordering concerns.
>
> Signed-off-by: Alan Cox <alan@...ux.intel.com>
> ---
>
>  drivers/tty/tty_ldisc.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
>
>
> diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
> index 173a900..833e851 100644
> --- a/drivers/tty/tty_ldisc.c
> +++ b/drivers/tty/tty_ldisc.c
> @@ -912,10 +912,13 @@ void tty_ldisc_release(struct tty_struct *tty, struct tty_struct *o_tty)
>         * race with the set_ldisc code path.
>         */
>
> -       tty_unlock(tty);
> +       /* We don't give a monkeys' about the o_tty lock here but we
> +          must do both to avoid lock inversions against another single
> +          locking case */
> +       tty_unlock_pair(tty, o_tty);
>        tty_ldisc_halt(tty);
>        tty_ldisc_flush_works(tty);
> -       tty_lock(tty);
> +       tty_lock_pair(tty, o_tty);

This still may cause lockdep warning by the following line:

             if (o_tty)
                    tty_ldisc_release(o_tty, NULL);

The tty_unlock_pair in 'tty_ldisc_release(o_tty, NULL)'  may
not match the previous tty_lock_pair. If tty > o_tty, then lockdep
warning will be triggered since the lock to be released is not
at the top of current lock stack.

Thanks,
-- 
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/