linux-kernel - [PATCH] mmc: avoid multiblock reads for the last sector in SPI mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1337965203-4211-1-git-send-email-bootc@bootc.net>
Date:	Fri, 25 May 2012 18:00:03 +0100
From:	Chris Boot <bootc@...tc.net>
To:	linux-mmc@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, Chris Boot <bootc@...tc.net>
Subject: [PATCH] mmc: avoid multiblock reads for the last sector in SPI mode

I was trying to get a Micro-SD card working over SPI today when I ran
into an issue which made the card unusable. The card was probed
correctly, and the msdos partition table was read, but then some command
was sent that made the card go into a bad state and stay that way. Only
a re-probe would get the card unstuck and only until just after the
partition tables were read.

After some digging I ran into a post [1] on the spi-devel-general mailing
list where someone had exactly the same issue as me, but back in 2007.
There was a patch attached which, after some cleanup, fixes the issue
completely for me.

I have tried this with 3 different Micro-SD cards, all of which suffered
from the problem before the patch and none of which fail after the
patch.

The error shows up as lots of:
mmcblk0: error -38 sending status comand, retrying
mmcblk0: error -38 sending status comand, retrying
mmcblk0: error -38 sending status comand, aborting

   1 : http://permalink.gmane.org/gmane.linux.kernel.spi.devel/516

Signed-off-by: Chris Boot <bootc@...tc.net>
---
 drivers/mmc/card/block.c |   10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index dabec55..8c5ff06 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -1139,6 +1139,16 @@ static void mmc_blk_rw_rq_prep(struct mmc_queue_req *mqrq,

 	if (brq->data.blocks > 1) {
 		/*
+		 * Some SD cards in SPI mode return a CRC error or even lock up
+		 * completely when trying to read the last block using a
+		 * multiblock read command.
+		 */
+		if (mmc_host_is_spi(card->host) && (rq_data_dir(req) == READ) &&
+				(blk_rq_pos(req) + blk_rq_sectors(req) ==
+					get_capacity(md->disk)))
+			brq->data.blocks--;
+
+		/*
 		 * After a read error, we redo the request one sector
 		 * at a time in order to accurately determine which
 		 * sectors can be read successfully.
-- 
1.7.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/