linux-kernel - [PATCH] mmc: Fix EINVAL if an mmc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1337965230-4589-1-git-send-email-bootc@bootc.net>
Date:	Fri, 25 May 2012 18:00:30 +0100
From:	Chris Boot <bootc@...tc.net>
To:	linux-mmc@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, Chris Boot <bootc@...tc.net>
Subject: [PATCH] mmc: Fix EINVAL if an mmc_spi controller has no IRQ

irq_of_parse_and_map() returns EINVAL if there is no interrupt
information available in device tree, not NO_IRQ. mmc_spi_get_pdata()
doesn't account for error returns, and ends up trying to
request_threaded_irq() with -22 as the IRQ value.

This patch checks for negative returns from irq_of_parse_and_map() as
well as NO_IRQ, and uses polled mode in those cases.

Signed-off-by: Chris Boot <bootc@...tc.net>
---
 drivers/mmc/host/of_mmc_spi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
index 1534b58..d3e882a 100644
--- a/drivers/mmc/host/of_mmc_spi.c
+++ b/drivers/mmc/host/of_mmc_spi.c
@@ -146,7 +146,7 @@ struct mmc_spi_platform_data *mmc_spi_get_pdata(struct spi_device *spi)
 		oms->pdata.get_ro = of_mmc_spi_get_ro;
 
 	oms->detect_irq = irq_of_parse_and_map(np, 0);
-	if (oms->detect_irq != NO_IRQ) {
+	if (oms->detect_irq != NO_IRQ && oms->detect_irq > 0) {
 		oms->pdata.init = of_mmc_spi_init;
 		oms->pdata.exit = of_mmc_spi_exit;
 	} else {
-- 
1.7.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/