linux-kernel - Re: [dm-devel] [PATCH v3 02/16] dm: Use bioset's front_pad for dm_rq_clone_bio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FC3645E.8040901@ce.jp.nec.com>
Date:	Mon, 28 May 2012 20:41:18 +0900
From:	"Jun'ichi Nomura" <j-nomura@...jp.nec.com>
To:	Kent Overstreet <koverstreet@...gle.com>
CC:	device-mapper development <dm-devel@...hat.com>, axboe@...nel.dk,
	linux-kernel@...r.kernel.org, tj@...nel.org,
	linux-bcache@...r.kernel.org, mpatocka@...hat.com, agk@...hat.com,
	bharrosh@...asas.com, linux-fsdevel@...r.kernel.org,
	yehuda@...newdream.net, drbd-dev@...ts.linbit.com,
	vgoyal@...hat.com, sage@...dream.net
Subject: Re: [dm-devel] [PATCH v3 02/16] dm: Use bioset's front_pad for dm_rq_clone_bio_info

On 05/28/12 09:57, Jun'ichi Nomura wrote:
> On 05/26/12 05:25, Kent Overstreet wrote:
>> -	pools->bs = bioset_create(pool_size, 0);
>> +	pools->bs = bioset_create(pool_size,
>> +				  offsetof(struct dm_rq_clone_bio_info, orig));
>>  	if (!pools->bs)
>>  		goto free_tio_pool_and_out;
> 
> Did you mean offset of *clone*?
> "offsetof(struct dm_rq_clone_bio_info, orig)" is zero.

Additional comment:
frontpad is not necessary if type is DM_TYPE_BIO_BASED.
Please check conditional switches done in the same function for
pools->tio_pool.

-- 
Jun'ichi Nomura, NEC Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/