linux-kernel - Re: [PATCH v2] Bluetooth: Really fix registering hci with duplicate name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120529074829.GB15895@aemeltch-MOBL1>
Date:	Tue, 29 May 2012 10:48:31 +0300
From:	Andrei Emeltchenko <andrei.emeltchenko.news@...il.com>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	Sasha Levin <levinsasha928@...il.com>, gustavo@...ovan.org,
	johan.hedberg@...il.com, davem@...emloft.net,
	linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Bluetooth: Really fix registering hci with duplicate
 name

Hi,

On Mon, May 28, 2012 at 05:47:48AM +0200, Marcel Holtmann wrote:
> Hi Sasha,
> 
> > Commit fc50744 ("Bluetooth: Fix registering hci with duplicate name") didn't
> > fully fix the duplicate naming issue with devices, and duplicate device names
> > could still be created:
> > 
> > [  142.484097] device: 'hci1': device_add
> > [...]
> > [  150.545263] device: 'hci1': device_add
> > [  150.550128] kobject: 'hci1' (ffff880014cc4e58): kobject_add_internal: parent: 'bluetooth', set: 'devices'
> > [  150.558979] ------------[ cut here ]------------
> > [  150.561438] WARNING: at fs/sysfs/dir.c:529 sysfs_add_one+0xb0/0xd0()
> > [  150.572974] Hardware name: Bochs
> > [  150.580502] sysfs: cannot create duplicate filename '/devices/virtual/bluetooth/hci1'
> > [  150.584444] Pid: 7563, comm: trinity-child1 Tainted: G        W    3.4.0-next-20120524-sasha #296
> > [...]
> > 
> > Instead of the weird logic and the attempt at keeping the device list sorted,
> > just use an IDA.
> > 
> > Signed-off-by: Sasha Levin <levinsasha928@...il.com>
> > ---
> > 
> > Changes from v1:
> > 
> >  - Address comments by Marcel.
> >  - Remove errornous mutex lock.
> > 
> >  net/bluetooth/hci_core.c |   41 ++++++++++++++++++++++++-----------------
> >  1 files changed, 24 insertions(+), 17 deletions(-)
> 
> thanks for addressing this. Patch has been applied to bluetooth-next
> tree.

The patch looks OK but I start to notice kmemleak messages like
shown below:

...
unreferenced object 0xf46e4ed8 (size 148):
  comm "modprobe", pid 656, jiffies 4294900233 (age 4661.940s)
  hex dump (first 32 bytes):
    00 00 00 00 40 4e 6e f4 00 00 00 00 00 00 00 00  ....@...........
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<c154dfcc>] kmemleak_alloc+0x3c/0xa0
    [<c1132c7a>] kmem_cache_alloc+0x14a/0x190
    [<c12af2dd>] idr_pre_get+0x5d/0x80
    [<c12af3e5>] ida_pre_get+0x15/0x90
    [<c12af497>] ida_simple_get+0x37/0xe0
    [<f8369b79>] 0xf8369b79
    [<f81be63e>] 0xf81be63e
    [<c13f2a5e>] usb_probe_interface+0xce/0x210
    [<c13733cb>] driver_probe_device+0x8b/0x370
    [<c1373749>] __driver_attach+0x99/0xa0
    [<c1371902>] bus_for_each_dev+0x42/0x70
    [<c1372ea1>] driver_attach+0x21/0x30
    [<c1372a47>] bus_add_driver+0x1c7/0x2e0
    [<c1373bf6>] driver_register+0x66/0x110
    [<c13f1acb>] usb_register_driver+0x7b/0x140
    [<f8005017>] 0xf8005017
unreferenced object 0xf454c260 (size 148):
  comm "modprobe", pid 656, jiffies 4294900233 (age 4661.940s)
  hex dump (first 32 bytes):
    00 00 00 00 d8 4e 6e f4 00 00 00 00 00 00 00 00  .....Nn.........
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<c154dfcc>] kmemleak_alloc+0x3c/0xa0
    [<c1132c7a>] kmem_cache_alloc+0x14a/0x190
    [<c12af2dd>] idr_pre_get+0x5d/0x80
    [<c12af3e5>] ida_pre_get+0x15/0x90
    [<c12af497>] ida_simple_get+0x37/0xe0
    [<f8369b79>] 0xf8369b79
    [<f81be63e>] 0xf81be63e
    [<c13f2a5e>] usb_probe_interface+0xce/0x210
    [<c13733cb>] driver_probe_device+0x8b/0x370
    [<c1373749>] __driver_attach+0x99/0xa0
    [<c1371902>] bus_for_each_dev+0x42/0x70
    [<c1372ea1>] driver_attach+0x21/0x30
    [<c1372a47>] bus_add_driver+0x1c7/0x2e0
    [<c1373bf6>] driver_register+0x66/0x110
    [<c13f1acb>] usb_register_driver+0x7b/0x140
    [<f8005017>] 0xf8005017
...

Best regards 
Andrei Emeltchenko 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/