linux-kernel - Re: [PATCH] prctl: Removed redunant assignment of "error" to zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKFnTyb7WBVP1xc444B90P3uOdhKt5PZGSfHBdWOiTNrQ@mail.gmail.com>
Date:	Wed, 30 May 2012 08:07:53 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Sasikantha babu <sasikanth.v19@...il.com>
Cc:	Serge Hallyn <serge.hallyn@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	James Morris <james.l.morris@...cle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] prctl: Removed redunant assignment of "error" to zero

On Wed, May 30, 2012 at 2:55 AM, Sasikantha babu
<sasikanth.v19@...il.com> wrote:
> Just setting the "error" to error number is enough on failure and
> It doesn't require to set "error" variable to zero in each switch case, since
> it was already initialized with zero

This looks fine. Can you include an additional clean up in this? It
looks like PR_SET_NAME and PR_GET_NAME both 'return 0' instead of
using 'break' like all the rest.

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/