linux-kernel - Re: [PATCH v5] regulator: MAX77686: Add Maxim 77686 regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120531124758.GE2666@opensource.wolfsonmicro.com>
Date:	Thu, 31 May 2012 13:47:58 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	jonghwa3.lee@...sung.com
Cc:	linux-kernel@...r.kernel.org, Liam Girdwood <lrg@...com>,
	Yadwinder Singh Brar <yadi.brar01@...il.com>,
	Chiwoong Byun <woong.byun@...sung.com>,
	Myungjoo Ham <myungjoo.ham@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH v5] regulator: MAX77686: Add Maxim 77686 regulator driver

On Thu, May 31, 2012 at 03:36:17PM +0900, jonghwa3.lee@...sung.com wrote:
> On 2012년 05월 31일 02:26, Mark Brown wrote:
> > On Tue, May 29, 2012 at 11:20:51AM +0900, Jonghwa Lee wrote:

> >> +#ifdef CONFIG_COMMON_CLK
> >> +	struct clk clk32khz_ap;
> >> +	struct clk clk32khz_cp;
> >> +	struct clk clk32khz_pmic;
> >> +#endif

> > This should be a clock driver in drivers/clock.

> Isn't it drivers/clk ? Could you explain more about this?

It's using the drivers/clk API, yes - what I'm saying is that you should
make a new MFD child driver drivers/clk/clk-max77686.c (or whatever) to
contain this code.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)