linux-kernel - RE: [PATCH 2/4] regmap: Make internal read/write functions reentrant from themselves.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <751C305CD2876B4990194D0512DE8BF2441CA8B6@SW-EX-MBX01.diasemi.com>
Date:	Thu, 31 May 2012 17:49:44 +0000
From:	Krystian Garbaciak <Krystian.Garbaciak@...semi.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Anthony Olech <Anthony.Olech@...semi.com>
Subject: RE: [PATCH 2/4] regmap: Make internal read/write functions
 reentrant from themselves.

> > The internal reading functions need no modification for current
> > implementation of indirect access.
> 
> So the subject should really be "Make internal write functions reentrant"?

Yes, it can be.

> We can't safely do this for all buses, some want to DMA and you can't DMA
> from stack.  This also means that we'll no longer be able to send a single buffer
> to the device as we'll never have the value immediately following the register
> address and padding any more.  That'll increase overhead on many systems, you
> can often see the handover on gathers on a scope.
> 
> I don't understand why we can't take the decision to write the page register
> before we start using the buffer?

I will try to solve this on next patch revision.

> Also, it seems like your mailing setup is a bit broken - these messages aren't
> being threaded with each other.

I've sent it like a bunch of new patches with different numbering, if that might be the reason.
Legal Disclaimer: This e-mail communication (and any attachment/s) is confidential and contains proprietary information, 
some or all of which may be legally privileged. It is intended solely for the use of the individual or entity to which it
is addressed. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, 
copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful.

Please consider the environment before printing this e-mail
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/