linux-kernel - RE: [PATCH 1/4] regmap: Reorganise internal read/write functions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <751C305CD2876B4990194D0512DE8BF2441CA8CA@SW-EX-MBX01.diasemi.com>
Date:	Thu, 31 May 2012 17:53:16 +0000
From:	Krystian Garbaciak <Krystian.Garbaciak@...semi.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Anthony Olech <Anthony.Olech@...semi.com>
Subject: RE: [PATCH 1/4] regmap: Reorganise internal read/write functions.

> On Thu, May 31, 2012 at 04:11:12PM +0200, Krystian Garbaciak wrote:
> 
> > +static int _regmap_raw_write(struct regmap *map, unsigned int reg,
> > +			     const void *val, size_t val_len) {
> > +	void *_val = (void *)val;
> 
> This is scary...  why are we casting away const here?

I will remove it from here.
However, on next patch I need to pass *val for reading and writing to the same function. I will put casting there and comment it.

Legal Disclaimer: This e-mail communication (and any attachment/s) is confidential and contains proprietary information, 
some or all of which may be legally privileged. It is intended solely for the use of the individual or entity to which it
is addressed. Access to this email by anyone else is unauthorized. If you are not the intended recipient, any disclosure, 
copying, distribution or any action taken or omitted to be taken in reliance on it, is prohibited and may be unlawful.

Please consider the environment before printing this e-mail
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/