linux-kernel - [PATCH v2] regmap: Fix the size calculation for map->format.buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 May 2012 22:07:35 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	broonie@...nsource.wolfsonmicro.com
Cc:	gregkh@...uxfoundation.org, marc@...esign.com.au,
	philippe.retornaz@...l.ch, linux-kernel@...r.kernel.org,
	joe@...ches.com, Fabio Estevam <fabio.estevam@...escale.com>
Subject: [PATCH v2] regmap: Fix the size calculation for map->format.buf_size

From: Fabio Estevam <fabio.estevam@...escale.com>

The word to be transmitted/received via regmap is composed by the following
parts:

config->reg_bits
config->val_bits
config->pad_bits

,so the total size should be calculated by summing up the number of bits of
each element and using a DIV_ROUND_UP to return the number of bytes.

While at it also use BITS_PER_BYTE annotation.

Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
---
Changes since v1:
- Use BITS_PER_BYTE annotation
 drivers/base/regmap/regmap.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 2aa076e..9d6b2f8 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -246,12 +246,12 @@ struct regmap *regmap_init(struct device *dev,
 		map->lock = regmap_lock_mutex;
 		map->unlock = regmap_unlock_mutex;
 	}
-	map->format.buf_size = (config->reg_bits + config->val_bits) / 8;
-	map->format.reg_bytes = DIV_ROUND_UP(config->reg_bits, 8);
-	map->format.pad_bytes = config->pad_bits / 8;
-	map->format.val_bytes = DIV_ROUND_UP(config->val_bits, 8);
-	map->format.buf_size += map->format.pad_bytes;
-	map->reg_shift = config->pad_bits % 8;
+	map->format.reg_bytes = DIV_ROUND_UP(config->reg_bits, BITS_PER_BYTE);
+	map->format.pad_bytes = config->pad_bits / BITS_PER_BYTE;
+	map->format.val_bytes = DIV_ROUND_UP(config->val_bits, BITS_PER_BYTE);
+	map->format.buf_size = DIV_ROUND_UP(config->reg_bits +
+			config->val_bits + config->pad_bits, BITS_PER_BYTE);
+	map->reg_shift = config->pad_bits % BITS_PER_BYTE;
 	if (config->reg_stride)
 		map->reg_stride = config->reg_stride;
 	else
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/