linux-kernel - Re: [PATCH v2 1/3] [RFC] Generic Red-Black Trees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FC81611.9090801@att.net>
Date:	Thu, 31 May 2012 20:08:33 -0500
From:	Daniel Santos <danielfsantos@....net>
To:	linux-kernel@...r.kernel.org
CC:	Kent Overstreet <koverstreet@...gle.com>, tj@...nel.org,
	Peter Zijlstra <peterz@...radead.org>, axboe@...nel.dk,
	paul.gortmaker@...driver.com, Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH v2 1/3] [RFC] Generic Red-Black Trees

Oh yeah, so the patch set I sent boots & runs fine.  I've also noticed
that I have a few outdated doc-comments and a mistake in the
doc-comments for
the BUILD_BUG_ON_NON_CONST2() macro, under the "Normal Variables"
section, the text "global non-static const broken until 4.2 (-O1 broken
until 4.4)" contradicts the earlier statement that all const values
should never fail. This only applies to floats (but not doubles), which
we don't have to worry about in the kernel anyway. (incidentally, their
behavior under __builtin_constant_p() varies quite a bit until gcc 4.4,
where it's fine)

It was important for me to figure out what was and wasn't working with
__builtin_constant_p(), and in what versions of gcc because this
implementation relies heavily on the compiler optimizing out code based
upon values pass to it via a const struct pointer.  Also, I was looking
for other possibilities, as I continued discovered broken (improperly
optimized) scenarios.

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/