linux-kernel - Re: 71ca97da9d overrides user's kernel config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyK_m8aO57gC4Q1PJXmY3e1-uRXQ3E6PRgdBVixJSa2gQ@mail.gmail.com>
Date:	Fri, 1 Jun 2012 10:53:20 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Vladimir 'φ-coder/phcoder' Serbinenko 
	<phcoder@...il.com>
Cc:	Emmanuel Benisty <benisty.e@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: 71ca97da9d overrides user's kernel config

On Fri, Jun 1, 2012 at 8:30 AM, Vladimir 'φ-coder/phcoder' Serbinenko
<phcoder@...il.com> wrote:
>
> Sorry, it wasn't intentional. It was just a stub to compile it without
> recompiling whole kernel. Should I supply the patch to remove it?

Yes, but I wonder if they should *also* be renamed, actually.

Those names are disgusting and unreadable, because the "MAC" part
mixes with the actual name of the codepage. I really have a hard time
reading something like MACROMANIAN, because to me it looks like it
starts with "MACRO". It's just a bad name.

Also, the CODEPAGE part adds questionable value. I wonder if we should
(a) remove the CODEPAGE part, (b) add an underscore between "MAC" and
the name, and for the microsoft numeric codepages, do the same just to
be consistent. IOW, use config names like NLS_DOS_1250 and
NLS_MAC_ROMANIAN?

(Yes, yes, I realize that people think that 1250 is a "windows"
codepage, not a DOS codepage. Use WIN_1250 if you want to, but I think
it's all really the same.)

I dunno. But start with the Mac ones first, since they need fixing
anyway. Leave the old ones alone for now.

Andrew, who would be in charge of "fs/nls"? Almost nobody has really
touched that area in several years now, and it doesn't have any
maintainership. Added the few poor sods that touched it last. "Tag,
guys, you're it!"

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/