linux-kernel - Re: 71ca97da9d overrides user's kernel config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 01 Jun 2012 20:14:06 +0200
From:	Vladimir 'φ-coder/phcoder' Serbinenko 
	<phcoder@...il.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Emmanuel Benisty <benisty.e@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: 71ca97da9d overrides user's kernel config


> Yes, but I wonder if they should *also* be renamed, actually.
> 
> Those names are disgusting and unreadable, because the "MAC" part
> mixes with the actual name of the codepage. I really have a hard time
> reading something like MACROMANIAN, because to me it looks like it
> starts with "MACRO". It's just a bad name.
> 

I agree. It was something I've seen used as charset name but quick
websearch shows better alternatives like "Mac Romanian", "Mac OS
Romanian". Should I rename the charsets themselves as well?

> Also, the CODEPAGE part adds questionable value. I wonder if we should
> (a) remove the CODEPAGE part, (b) add an underscore between "MAC" and
> the name, and for the microsoft numeric codepages, do the same just to
> be consistent. IOW, use config names like NLS_DOS_1250 and
> NLS_MAC_ROMANIAN?

I'm ok with changing my newly-added charsets but I think that there is
no reason to rename already existing ones. It would just add a bunch of
new questions at reconfigure not corresponding to any real
functionality. Also, I believe, that the whole reason of NLS codepage
tables to exist is the ability to read old volumes and marginally the
ability to interchange data with old OS in a best available way. The
least it used for any purpose outside speaking with old OS or touching
old volumes, the better.
I'll prepare 2 patches: cleanup, config rename and codepage rename.
-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko


Download attachment "signature.asc" of type "application/pgp-signature" (295 bytes)