lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 Jun 2012 09:39:20 +0300 (EEST) From: Pekka Enberg <penberg@...nel.org> To: David Rientjes <rientjes@...gle.com> cc: Joonsoo Kim <js1304@...il.com>, Christoph Lameter <cl@...ux-foundation.org>, linux-kernel@...r.kernel.org, linux-mm@...ck.org, torvalds@...ux-foundation.org Subject: Re: [PATCH] slub: change cmpxchg_double_slab in get_freelist() to __cmpxchg_double_slab On Mon, 14 May 2012, David Rientjes wrote: > > On Fri, 11 May 2012, Joonsoo Kim wrote: > > > > > get_freelist() is only called by __slab_alloc with interrupt disabled, > > > so __cmpxchg_double_slab is suitable. > > > > > > Signed-off-by: Joonsoo Kim <js1304@...il.com> > > > > Acked-by: David Rientjes <rientjes@...gle.com> On Thu, 31 May 2012, David Rientjes wrote: > Pekka, did you want to pick this up so it can get into linux-next? We now made get_freelist() *require* interrupts to be disabled which deserves a comment, no? Also, what do we gain from patches like this? It's somewhat counterintuitive that we have a function with "cmpxchg" in it which is not always atomic (i.e. you need to have interrupts disabled). IIRC, there was even a long rant about this by Linus but I'm unable to find it in my email archives. Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists