linux-kernel - Re: [PATCH] slimbus: Linux driver framework for SLIMbus.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69926c6ce4b1e004069662fb13287e9b.squirrel@www.codeaurora.org>
Date:	Mon, 4 Jun 2012 03:36:55 -0700 (PDT)
From:	"Sagar Dharia" <sdharia@...eaurora.org>
To:	"Mark Brown" <broonie@...nsource.wolfsonmicro.com>
Cc:	"Sagar Dharia" <sdharia@...eaurora.org>, davidb@...eaurora.org,
	bryanh@...eaurora.org, kheitke@...eaurora.org,
	gclemson@...ience.com, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, rob@...dley.net,
	grant.likely@...retlab.ca, rob.herring@...xeda.com,
	ohad@...ery.com, gregkh@...uxfoundation.org,
	linus.walleij@...aro.org, rusty@...tcorp.com.au,
	joerg.roedel@....com, trenn@...e.de, ak@...ux.intel.com,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH] slimbus: Linux driver framework for SLIMbus.


>> While taking care of the comments for RFC, I have introduced a
>> completion
>> that will be signalled when LA is given to the device. The driver can
>> wait
>> on that completion (wait_enum) instead of polling.
>
> This would mean that the thread the probe is happening in will be
> blocked until the LA is assigned.  That sounds like it might cause
> problems, either slowing things down or worst case causing a deadlock.
>
I would expect that the slim_device's driver will only power-on the device
during probe (and use wait_for_completion during 1st transfer to get LA).
Typically transfers are not done as part of probe. Even if transfers need
to be done as part of probe, I expect wait_for_completion (with timeout to
avoid potential HW problems causing linux probe to wait forever) will be
better than polling for get_logical_addr.


Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/