linux-kernel - Re: [tip:perf/core] perf/x86: Fix wrmsrl() debug wrapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 06 Jun 2012 19:12:27 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	mingo@...nel.org, linux-kernel@...r.kernel.org, tglx@...utronix.de,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/core] perf/x86: Fix wrmsrl() debug wrapper

On Wed, 2012-06-06 at 09:21 -0700, H. Peter Anvin wrote:
> On 06/06/2012 09:15 AM, tip-bot for Peter Zijlstra wrote:
> > 
> > perf/x86: Fix wrmsrl() debug wrapper
> > 
> > Move the wrmslr() debug wrapper to the common header now that all the
> > include games are gone. Also clean it up a bit to avoid multiple
> > evaluation of the argument.
> > 
> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > Link: http://lkml.kernel.org/n/tip-l4gkfnivwv4yi5mqxjlovymx@git.kernel.org
> > Signed-off-by: Ingo Molnar <mingo@...nel.org>
> 
> Could you please call this something like trace_wrmsrl() instead of
> silently tacking something onto something else that already had meaning?

Its #if 0, its broken on CONFIG_PARAVIRT etc.. The whole purpose was to
hijack wrmsrl() for perf_event*.c so that I don't have to do
s/wrmsrl/trace_&/ on those files.

Its a crude debug aid, nothing more.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/