linux-kernel - Re: [PATCH] gpiolib: wm8994: Pay attention to the value set when enabling as output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdY379kHbaMhGD4Q9y=Nkv2NPey+n1zUuTLAE-j7f8gadA@mail.gmail.com>
Date:	Thu, 7 Jun 2012 13:11:20 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] gpiolib: wm8994: Pay attention to the value set when
 enabling as output

On Tue, Jun 5, 2012 at 7:12 PM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:

> +       if (value)
> +               value = WM8994_GPN_LVL;
> +
>        return wm8994_set_bits(wm8994, WM8994_GPIO_1 + offset,
> -                              WM8994_GPN_DIR, 0);
> +                              WM8994_GPN_DIR | WM8994_GPN_LVL, value);
>  }

The commit message is so terse compared to what the code does that
I cannot claim to understand what this patch is doing.

Could you elaborate on the problem ans symptoms, just for a nice
commit log?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/