linux-kernel - Re: [PATCH] gpiolib: wm8994: Pay attention to the value set when enabling as output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jun 2012 22:53:05 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] gpiolib: wm8994: Pay attention to the value set when
 enabling as output

On Thu, Jun 07, 2012 at 01:11:20PM +0200, Linus Walleij wrote:
> <broonie@...nsource.wolfsonmicro.com> wrote:

> > + ? ? ? if (value)
> > + ? ? ? ? ? ? ? value = WM8994_GPN_LVL;

> > ? ? ? ?return wm8994_set_bits(wm8994, WM8994_GPIO_1 + offset,
> > - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?WM8994_GPN_DIR, 0);
> > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?WM8994_GPN_DIR | WM8994_GPN_LVL, value);
> > ?}

> The commit message is so terse compared to what the code does that
> I cannot claim to understand what this patch is doing.

> Could you elaborate on the problem ans symptoms, just for a nice
> commit log?

I'm not really sure what more there is to say...  previously we were
ignoring the value that's set as part of setting output mode so if
someone wanted to set a value different to the one the chip happened to
have that wouldn't happen.  Ignoring the vaue that the user is trying to
set seems like an obvious enough bug in itself.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/