linux-kernel - Re: [PATCH RT 3/4] mips-remove-smp-reserve-lock.patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 07 Jun 2012 10:50:49 -0700
From:	David Daney <ddaney.cavm@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	linux-kernel@...r.kernel.org,
	linux-rt-users <linux-rt-users@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Carsten Emde <C.Emde@...dl.org>,
	John Kacur <jkacur@...hat.com>,
	Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [PATCH RT 3/4] mips-remove-smp-reserve-lock.patch

On 06/07/2012 08:51 AM, Steven Rostedt wrote:
> From: Thomas Gleixner<tglx@...utronix.de>
>
> Instead of making the lock raw, remove it as it protects nothing.

I don't know how you guys are managing the RT branch, but this seems 
quite similar to:

a3c8b4faeeccb33dbad6969bc9e50bf409f167e7 (MIPS: Cavium: Remove 
smp_reserve_lock.)

David Daney


>
> Signed-off-by: Thomas Gleixner<tglx@...utronix.de>
> Cc: stable-rt@...r.kernel.org
> Signed-off-by: Steven Rostedt<rostedt@...dmis.org>
> ---
>   arch/mips/cavium-octeon/smp.c |    6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
> index efcfff4..86fce15 100644
> --- a/arch/mips/cavium-octeon/smp.c
> +++ b/arch/mips/cavium-octeon/smp.c
> @@ -257,8 +257,6 @@ DEFINE_PER_CPU(int, cpu_state);
>
>   extern void fixup_irqs(void);
>
> -static DEFINE_SPINLOCK(smp_reserve_lock);
> -
>   static int octeon_cpu_disable(void)
>   {
>   	unsigned int cpu = smp_processor_id();
> @@ -266,8 +264,6 @@ static int octeon_cpu_disable(void)
>   	if (cpu == 0)
>   		return -EBUSY;
>
> -	spin_lock(&smp_reserve_lock);
> -
>   	cpu_clear(cpu, cpu_online_map);
>   	cpu_clear(cpu, cpu_callin_map);
>   	local_irq_disable();
> @@ -277,8 +273,6 @@ static int octeon_cpu_disable(void)
>   	flush_cache_all();
>   	local_flush_tlb_all();
>
> -	spin_unlock(&smp_reserve_lock);
> -
>   	return 0;
>   }
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/