linux-kernel - Re: [ 31/82] mm/vmalloc.c: change void* into explict vm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1339157775.21665.115.camel@deadeye.wl.decadent.org.uk>
Date:	Fri, 08 Jun 2012 13:16:15 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Rientjes <rientjes@...gle.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, Minchan Kim <minchan@...nel.org>
Subject: Re: [ 31/82] mm/vmalloc.c: change void* into explict vm_struct*

On Fri, 2012-06-08 at 03:41 -0700, David Rientjes wrote:
> On Fri, 8 Jun 2012, Ben Hutchings wrote:
> 
> > 3.2-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Minchan Kim <minchan@...nel.org>
> > 
> > commit db1aecafef58b5dda39c4228debe2c845e4a27ab upstream.
> > 
> > vmap_area->private is void* but we don't use the field for various purpose
> > but use only for vm_struct.  So change it to a vm_struct* with naming to
> > improve for readability and type checking.
> > 
> > Signed-off-by: Minchan Kim <minchan@...nel.org>
> > Acked-by: David Rientjes <rientjes@...gle.com>
> > Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> > Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> > Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> 
> I'm not sure this is stable material and it wasn't annotated as such when 
> it was commited, why should someone need to upgrade their 3.2 for a patch 
> like this?

It allows the next one (commit dbda591d920b4c7692725b13e3f68ecb251e9080,
'mm: fix faulty initialization in vmalloc_init()') apply cleanly.  So,
unless it causes some harm, I'll keep it.

Ben.

-- 
Ben Hutchings
I haven't lost my mind; it's backed up on tape somewhere.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)