linux-kernel - Re: Does perf inject preserve call chain data?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120608143843.GA9954@infradead.org>
Date:	Fri, 8 Jun 2012 11:38:43 -0300
From:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To:	David Ahern <dsahern@...il.com>
Cc:	Tim Chen <tim.c.chen@...ux.intel.com>,
	linux-kernel <linux-kernel@...r.kernel.org>, ak@...ux.intel.com,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: Does perf inject preserve call chain data?

Em Tue, May 22, 2012 at 03:58:40PM -0600, David Ahern escreveu:
> On 5/22/12 12:49 PM, Tim Chen wrote:
> >Arnaldo,
> >
> >Wonder if perf inject munged the call chain data from perf record?
> >
> >When I do
> >perf record -a -g -o - sleep 5 |perf inject -v -b  | perf report  -g -i -
> >I get a complain from perf report
> >
> >Warning:
> >Selected -g but no callchain data. Did you call 'perf record' without -g?
> >
> 
> I believe the root cause is that the event list is not written to
> the pipe. Using Arnaldo's git repo as of today (has fixes from
> Stephane) this hack shows the info is there and can be processed.

How things stand here? Tim, did this fix things for you? If so, David,
please resend with a proper subject line and a Tested-by: Tim, ok?

Thanks,

- Arnaldo
 
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index d58e414..60f3f17 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -256,7 +257,7 @@ static int perf_report__setup_sample_type(struct
> perf_report *rep)
>                     "'perf record' without -g?\n");
>             return -EINVAL;
>         }
> -       if (symbol_conf.use_callchain) {
> +       if (!self->fd_pipe && symbol_conf.use_callchain) {
>             ui__warning("Selected -g but no callchain data. Did "
>                     "you call 'perf record' without -g?\n");
>             return -1;
> 
> A proper solution is needed.
> 
> David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/