linux-kernel - Re: [PATCH] x86,nmi: Fix section mismatch warnings on 32-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120608020654.GA18530@redhat.com>
Date:	Thu, 7 Jun 2012 22:06:54 -0400
From:	Don Zickus <dzickus@...hat.com>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Jan Beulich <JBeulich@...e.com>, x86@...nel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86,nmi: Fix section mismatch warnings on 32-bit

On Tue, Jun 05, 2012 at 07:22:08PM +0200, Sam Ravnborg wrote:
> > >> I do not know enough about behind the scene compiler magic to track this
> > >> down correctly.  So any insight/help is greatly appreciated. :-)
> > > 
> > > We register a function annotated __init. And the normal use of this 
> > > register()
> > > is for functions that survive the init phase.
> > > So drop the __init annotation on the function we register and the mismatch 
> > > is fixed.
> > 
> > But in the case here the function really is being used at init time
> > only.
> This is only for testing. Ando nly if CONFIG_DEBUG_NMI_SELFTEST is set.

Hi Sam,

Sorry for ignoring your responses before.  Somehow your emails were not
hitting my inbox for some reason, but I found them in my lkml folder.

So I am confused on the right way to fix this.

Sam is saying drop the __init and Jan is suggesting add __initdata for
these two special cases.

Anyone want to break the tie? :-)

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/