linux-kernel - Re: [PATCH] Remove lib/mpi/generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jun 2012 11:27:32 +0300
From:	"Kasatkin, Dmitry" <dmitry.kasatkin@...el.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Remove lib/mpi/generic_mpi-asm-defs.h

Hello,

Indeed like that...
That patch has been already reverted and unused code removed.
Changes are available in the #next-queue branch of Linux security tree.

Thanks!

- Dmitry

On Fri, Jun 8, 2012 at 6:33 PM, Paul Bolle <pebolle@...cali.nl> wrote:
> This header got added by commit 7e8dec918ef8e0f68b4937c3c50fa57002077a4d
> ("crypto: GnuPG based MPI lib - additional sources (part 4)"). Nothing
> includes it.
>
> The sole named constant it defines is BYTES_PER_MPI_LIMB. That named
> constant is already provided by <linux/mpi.h> (which is made available
> to the files in lib/mpi via mpi-internal.h). In this header that define
> depends on the undefined macro SIZEOF_UNSIGNED_LONG.
>
> So this header is unused, unneeded and broken. It can safely be removed.
>
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> ---
> This patch is, once again, tested only with "git grep".
>
>  lib/mpi/generic_mpi-asm-defs.h |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
>  delete mode 100644 lib/mpi/generic_mpi-asm-defs.h
>
> diff --git a/lib/mpi/generic_mpi-asm-defs.h b/lib/mpi/generic_mpi-asm-defs.h
> deleted file mode 100644
> index 047d1f5..0000000
> --- a/lib/mpi/generic_mpi-asm-defs.h
> +++ /dev/null
> @@ -1,4 +0,0 @@
> -/* This file defines some basic constants for the MPI machinery.  We
> - * need to define the types on a per-CPU basis, so it is done with
> - * this file here.  */
> -#define BYTES_PER_MPI_LIMB  (SIZEOF_UNSIGNED_LONG)
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/