linux-kernel - Re: [PATCH] Staging: ipack: remove pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120611082902.GU4400@mwanda>
Date:	Mon, 11 Jun 2012 11:29:02 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Samuel Iglesias Gonsálvez 
	<siglesias@...lia.com>
Cc:	devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: ipack: remove pr_fmt definition.

On Mon, Jun 11, 2012 at 09:40:04AM +0200, Samuel Iglesias Gonsálvez wrote:
> On Mon, 2012-06-11 at 10:27 +0300, Dan Carpenter wrote:
> > On Mon, Jun 11, 2012 at 10:25:00AM +0300, Dan Carpenter wrote:
> > > On Mon, Jun 11, 2012 at 08:56:36AM +0200, Samuel Iglesias Gonsalvez wrote:
> > > > As there is no pr_* function used here, pr_fmt is not needed.
> > > > 
> > > 
> > > Nah.  What about if we decide to add some?  Also there are actually
> > > a couple pr_err() calls in there already.
> > 
> > Oops.  Sorry my tree is old.  We removed the two calls to pr_err().
> 
> Same mistake here. In greg's staging-next the pr_err calls are not
> present so the patch is totally valid but in linus branch they are there
> (this is the reason of my error).
> 
> So, this patch is valid, unless we want the pr_fmt definition for the
> future. However, I prefer to delete it.
> 

Sure.  I guess everything in staging/ipack/ uses dev_err() type
print statements and that includes more information than the the
pr_fmt() macro already.

Acked-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/