[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4FD60127.1000805@jp.fujitsu.com>
Date: Mon, 11 Jun 2012 10:31:03 -0400
From: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To: cl@...ux.com
CC: kosaki.motohiro@...il.com, linux-kernel@...r.kernel.org,
linux-mm@...ck.org, kosaki.motohiro@...fujitsu.com
Subject: Re: [PATCH] mm: fix protection column misplacing in /proc/zoneinfo
On 6/11/2012 10:02 AM, Christoph Lameter wrote:
> On Mon, 11 Jun 2012, kosaki.motohiro@...il.com wrote:
>
>> From: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
>>
>> commit 2244b95a7b (zoned vm counters: basic ZVC (zoned vm counter)
>> implementation) broke protection column. It is a part of "pages"
>> attribute. but not it is showed after vmstats column.
>>
>> This patch restores the right position.
>
> Well this reorders the output. vmstats are also counts of pages. I am not
> sure what the difference is.
No. In this case, "pages" mean zone attribute. In the other hand, vmevent
is a statistics.
> You are not worried about breaking something that may scan the zoneinfo
> output with this change? Its been this way for 6 years and its likely that
> tools expect the current layout.
I don't worry about this. Because of, /proc/zoneinfo is cray machine unfrinedly
format and afaik no application uses it.
btw, I believe we should aim /sys/devices/system/node/<node-num>/zones new directory
and export zone infos as machine readable format.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists