| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20120610.202341.2146277133562218686.davem@davemloft.net> Date: Sun, 10 Jun 2012 20:23:41 -0700 (PDT) From: David Miller <davem@...emloft.net> To: mst@...hat.com Cc: eric.dumazet@...il.com, jasowang@...hat.com, netdev@...r.kernel.org, rusty@...tcorp.com.au, linux-kernel@...r.kernel.org, virtualization@...ts.linux-foundation.org, shemminger@...tta.com Subject: Re: [PATCH] virtio-net: fix a race on 32bit arches From: "Michael S. Tsirkin" <mst@...hat.com> Date: Sun, 10 Jun 2012 13:25:12 +0300 > On Wed, Jun 06, 2012 at 10:35:24AM +0200, Eric Dumazet wrote: >> From: Eric Dumazet <edumazet@...gle.com> >> >> commit 3fa2a1df909 (virtio-net: per cpu 64 bit stats (v2)) added a race >> on 32bit arches. >> >> We must use separate syncp for rx and tx path as they can be run at the >> same time on different cpus. Thus one sequence increment can be lost and >> readers spin forever. >> >> Signed-off-by: Eric Dumazet <edumazet@...gle.com> >> Cc: Stephen Hemminger <shemminger@...tta.com> >> Cc: Michael S. Tsirkin <mst@...hat.com> >> Cc: Jason Wang <jasowang@...hat.com> > > I'm still thinking about moving tx to take a xmit lock long term, > meanwhile this fix appears appropriate for 3.5. > > Acked-by: Michael S. Tsirkin <mst@...hat.com> > > Dave, can you pick this up pls? Done, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists