[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1339448210.19977.2.camel@joe2Laptop>
Date: Mon, 11 Jun 2012 13:56:50 -0700
From: Joe Perches <joe@...ches.com>
To: Don Zickus <dzickus@...hat.com>
Cc: LKML <linux-kernel@...r.kernel.org>, nzimmer@....com,
Ingo Molnar <mingo@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v3] watchdog: Quiet down the boot messages
On Mon, 2012-06-11 at 16:04 -0400, Don Zickus wrote:
> A bunch of bugzillas have complained how noisy the nmi_watchdog is during
> boot-up especially with its expected failure cases (like virt and bios
> resource contention).
[]
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
[]
> @@ -390,11 +397,23 @@ static int watchdog_nmi_enable(int cpu)
[]
> if (!IS_ERR(event)) {
> - pr_info("enabled, takes one hw-pmu counter.\n");
> + /* only print for cpu0 or different than cpu0 */
> + if (cpu == 0 || cpu0_err) {
> + pr_info("enabled on all CPUs, permanently consumes ");
> + pr_cont("one hw-PMU counter.\n");
Don't worry about formats exceeding 80 column please.
Don't break up pr_info into multiple bits either.
pr_info("enabled on all cpus, permanently consumes one hw-PMU counter\n");
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists