linux-kernel - Re: [PATCH v3 2/4] usb: storage: add support for write cache quirk on usb hdd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Jun 2012 07:50:01 +0900
From:	Namjae Jeon <linkinjeon@...il.com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	James.Bottomley@...senpartnership.com, gregkh@...uxfoundation.org,
	mdharm-usb@...-eyed-alien.net, stern@...land.harvard.edu,
	bvanassche@....org, linux-usb@...r.kernel.org,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Namjae Jeon <namjae.jeon@...sung.com>,
	Pankaj Kumar <pankaj.km@...sung.com>,
	Amit Sahrawat <a.sahrawat@...sung.com>
Subject: Re: [PATCH v3 2/4] usb: storage: add support for write cache quirk on
 usb hdd

2012/6/12, Sergei Shtylyov <sshtylyov@...sta.com>:
> Hello.
>
> On 10-06-2012 4:30, Namjae Jeon wrote:
>
>>>> Add support for write cache quirk on usb hdd. scsi driver will be set
>>>> to
>>>> wce
>>>> by detecting write cache quirk in quirk list when plugging usb hdd.
>
>>>> Signed-off-by: Namjae Jeon<namjae.jeon@...sung.com>
>>>> Signed-off-by: Pankaj Kumar<pankaj.km@...sung.com>
>>>> Signed-off-by: Amit Sahrawat<a.sahrawat@...sung.com>
>>>> ---
>>>>    drivers/usb/storage/scsiglue.c |    5 +++++
>>>>    drivers/usb/storage/usb.c      |    5 ++++-
>>>>    include/linux/usb_usual.h      |    4 +++-
>>>>    3 files changed, 12 insertions(+), 2 deletions(-)
>
>>>> diff --git a/drivers/usb/storage/scsiglue.c
>>>> b/drivers/usb/storage/scsiglue.c
>>>> index a324a5d..fe42547 100644
>>>> --- a/drivers/usb/storage/scsiglue.c
>>>> +++ b/drivers/usb/storage/scsiglue.c
>>> [...]
>>>> @@ -529,6 +529,9 @@ static void adjust_quirks(struct us_data *us)
>>>>    		case 'o':
>>>>    			f |= US_FL_CAPACITY_OK;
>>>>    			break;
>>>> +		case 'p':
>>>> +			f |= US_FL_WRITE_CACHE;
>>>> +			break;
>>>>    		case 'r':
>>>>    			f |= US_FL_IGNORE_RESIDUE;
>>>>    			break;
>>>
>>>      You probably should unite this chunk with the documentation update
>>> patch.
>
>> Hi Sergei.
>> I tried to post documentation update patch(4/4) for this chunk.
>> Do I misunderstand ?
>
>     I mean that the documenation should be updated in the same patch where
> you
> add the new value.
Okay, I changed it on the latest patch also.
Sergei, Thanks a lot.
>
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/