linux-kernel - Re: [PATCH] include: Fix compile warning in include/linux/bitops.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120611155919.7decee80.akpm@linux-foundation.org>
Date:	Mon, 11 Jun 2012 15:59:19 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	arnd@...db.de, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] include: Fix compile warning in include/linux/bitops.h

On Fri,  8 Jun 2012 23:15:30 -0400
Namjae Jeon <linkinjeon@...il.com> wrote:

> The compile warning is caused by __const_hweight8 when using
> hweight_long with -Wsign-compare option.
> The reason is that the default return value of this macro is signed.
> So need type casting to remove warning.

um, what warning?

Please always quote the compiler messages when fixing build warnings or
errors.

> index fa2a50b..3ad0dae 100644
> --- a/include/asm-generic/bitops/const_hweight.h
> +++ b/include/asm-generic/bitops/const_hweight.h
> @@ -4,7 +4,7 @@
>  /*
>   * Compile time versions of __arch_hweightN()
>   */
> -#define __const_hweight8(w)		\
> +#define __const_hweight8(w)	(unsigned long)	\
>        (	(!!((w) & (1ULL << 0))) +	\
>  	(!!((w) & (1ULL << 1))) +	\
>  	(!!((w) & (1ULL << 2))) +	\

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/