linux-kernel - Re: [PATCH 8/8] staging: comedi: cleanup comedi_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120612194940.GZ4400@mwanda>
Date:	Tue, 12 Jun 2012 22:49:40 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	devel@...verdev.osuosl.org, fmhess@...rs.sourceforge.net,
	abbotti@....co.uk, gregkh@...uxfoundation.org
Subject: Re: [PATCH 8/8] staging: comedi: cleanup comedi_alloc_subdevices

On Tue, Jun 12, 2012 at 11:59:55AM -0700, H Hartley Sweeten wrote:
>  	for (i = 0; i < num_subdevices; ++i) {
> -		dev->subdevices[i].device = dev;
> -		dev->subdevices[i].async_dma_dir = DMA_NONE;
> -		spin_lock_init(&dev->subdevices[i].spin_lock);
> -		dev->subdevices[i].minor = -1;
> +		s = dev->subdevices + i;

You don't have to resend, but I think this would look better as:

		s = &dev->subdevices[i];

> +		s->device = dev;
> +		s->async_dma_dir = DMA_NONE;
> +		spin_lock_init(&s->spin_lock);
> +		s->minor = -1;
>  	}

Btw, this patchset is great.  Nice.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/