linux-kernel - Re: gma500: Cannot find any crtc or sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120612212302.7a4ec41c@pyramind.ukuu.org.uk>
Date:	Tue, 12 Jun 2012 21:23:02 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Patrik Jakobsson <patrik.r.jakobsson@...il.com>
Cc:	Christian Gmeiner <christian.gmeiner@...il.com>,
	linux-kernel@...r.kernel.org, Greg Kroah-Hartman <greg@...ah.com>
Subject: Re: gma500: Cannot find any crtc or sizes - going 1024x768

> It matters because everything between 0x4100 - 0x4107 are Moorestown if you ask
> the macro, but are assigned to oaktrail_chip_ops. That makes Oaktrail ==
> Moorestown. IS_OAK might be a more appropriate name.

Oaktrail is sort of Moorestown, the divide is whether they have a PC like
set of I/O devices or not. It reflects the history of the driver


> IS_MRST is primarily used for two things:
> 1) Take LVDS enable fuse value into account

This like the non PC BIOS parsing should probably go. I've not taken it
out yet because I wanted to prove this. I'd be very surprised if it's the
right way to handle E600T but there's a bit of a lack of any public info
on that so who knows 8(.

> 2) Tell that LVDS must be on Pipe A

Which is true for Oaktrail and it seems E600T

> Those things where required for him to get the panel working,
> so why not include the 0x4108 in the IS_MRST check?

We probably want IS_GMA600() rather than IS_MRST.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/