linux-kernel - RE: [PATCH v7 1/3] mmc: core: Add packed command feature of eMMC4.5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <001a01cd4849$3f287180$bd795480$%jun@samsung.com>
Date:	Tue, 12 Jun 2012 12:12:49 +0900
From:	Seungwon Jeon <tgih.jun@...sung.com>
To:	merez@...eaurora.org
Cc:	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	'Chris Ball' <cjb@...top.org>,
	'Subhash Jadavani' <subhashj@...eaurora.org>,
	"'S, Venkatraman'" <svenkatr@...com>
Subject: RE: [PATCH v7 1/3] mmc: core: Add packed command feature of eMMC4.5

Maya Erez <merez@...eaurora.org> wrote:
> > +	if ((host->caps2 & MMC_CAP2_PACKED_CMD) &&
> > +			((card->ext_csd.max_packed_writes > 0) ||
> > +			(card->ext_csd.max_packed_reads > 0))) {
> > +		err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
> > +				EXT_CSD_EXP_EVENTS_CTRL,
> > +				EXT_CSD_PACKED_EVENT_EN,
> > +				card->ext_csd.generic_cmd6_time);
> > +		if (err && err != -EBADMSG)
> > +			goto free_card;
> 
> Subhash suggestion to change to the following is missing:
>      if (  (host->caps2 & MMC_CAP2_PACKED_WR &&
> card->ext_csd.max_packed_writes > 0) ||
>             (host->caps2 & MMC_CAP2_PACKED_RD &&
> card->ext_csd.max_packed_reads > 0)
Thanks to detect.
It'll be applied.

Best regards,
Seungwon Jeon

> 
> Thanks,
> Maya Erez
> Consultant for Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/