linux-kernel - Re: [PATCH v2] lib/decompress_unxz.c: removing all memory helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FD6B472.7040609@zytor.com>
Date:	Mon, 11 Jun 2012 20:16:02 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	T Makphaibulchoke <tmac@...com>
CC:	linux@....linux.org.uk, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, linux390@...ibm.com,
	lethal@...ux-sh.org, tglx@...utronix.de, mingo@...hat.com,
	x86@...nel.org, kaloz@...nwrt.org, nicolas.pitre@...aro.org,
	jj@...osbits.net, matt.fleming@...el.com, lasse.collin@...aani.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-s390@...r.kernel.org, linux-sh@...r.kernel.org
Subject: Re: [PATCH v2] lib/decompress_unxz.c: removing all memory helper
 functions

On 06/11/2012 08:05 PM, T Makphaibulchoke wrote:
> Cleaning up the file lib/decompress_unxz.c, moving all memory helper functions,
> e.g. memmove, to a new common source file, lib/boot/mem.c.
> 
> In additon to including the decompressor, any architecture supporting the XZ
> decompression needs to also include this new source file.
> 
> Also moving some other duplicated memory helper functions to this new source
> file from the arm, s390, sh and x86 preboot environments.  All 4 architectures
> build without error when using any compression.
> 
> Adding a new file lib/boot/mem.c, containing memory helper functions required
> by different compression types.
> 
> Adding memcmp declaration workaround and removing the memmove and memcpy
> defines workaround from arch/arm/boot/compressed/decompress.c
> 
> Removing the common functions, memmove, memcmp and memset, and adding the new
> source file include to arch/arm/boot/compressed/string.c.
> 
> Removing the memcpy and memmove functions and adding the new source file
> include to arch/s390/boot/compressed/misc.c.
> 
> Removing the memset function and adding the new source file include to
> arch/sh/boot/compressed/misc.c
> 
> Removing the memset function from arch/x86/boot/compressed/misc.c and move
> the memcpy function to the file arch/x86/boot/compressed/string.c
> 
> Adding the memcpy function and the new source file include to
> arch/x86/boot/compressed/string.c
> 

I can take this if Russell, Martin or Heiko, and Paul are willing to ack it.

	-hpa


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/