linux-kernel - [tip:sched/numa] sched/numa: Allocate 'struct node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-1f49a99116069a8d9dc6027862277a766c2ef17e@git.kernel.org>
Date:	Wed, 13 Jun 2012 06:36:22 -0700
From:	tip-bot for David Rientjes <rientjes@...gle.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...nel.org,
	torvalds@...ux-foundation.org, peterz@...radead.org,
	lee.schermerhorn@...com, tglx@...utronix.de, sfr@...b.auug.org.au,
	rientjes@...gle.com
Subject: [tip:sched/numa] sched/numa: Allocate 'struct node_queue'
  on any node for offline nodes

Commit-ID:  1f49a99116069a8d9dc6027862277a766c2ef17e
Gitweb:     http://git.kernel.org/tip/1f49a99116069a8d9dc6027862277a766c2ef17e
Author:     David Rientjes <rientjes@...gle.com>
AuthorDate: Tue, 22 May 2012 21:17:56 -0700
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Wed, 13 Jun 2012 15:25:37 +0200

sched/numa: Allocate 'struct node_queue' on any node for offline nodes

'struct node_queue' must be allocated with NUMA_NO_NODE for nodes
that are not (yet) online, otherwise the page allocator has a
bad zonelist and results in an early crash.

Tested-by: Stephen Rothwell <sfr@...b.auug.org.au>
Signed-off-by: David Rientjes <rientjes@...gle.com>
Cc: linuxppc-dev@...ts.ozlabs.org
Cc: Lee Schermerhorn <lee.schermerhorn@...com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Link: http://lkml.kernel.org/r/alpine.DEB.2.00.1205222116160.32649@chino.kir.corp.google.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 kernel/sched/numa.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/kernel/sched/numa.c b/kernel/sched/numa.c
index 77fa7d4..002f71c 100644
--- a/kernel/sched/numa.c
+++ b/kernel/sched/numa.c
@@ -829,7 +829,8 @@ static __init int numa_init(void)
 
 	for_each_node(node) {
 		struct node_queue *nq = kmalloc_node(sizeof(*nq),
-				GFP_KERNEL | __GFP_ZERO, node);
+				GFP_KERNEL | __GFP_ZERO,
+				node_online(node) ? node : NUMA_NO_NODE);
 		BUG_ON(!nq);
 
 		spin_lock_init(&nq->lock);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/